On 11/06/2012 03:55 AM, Omar Ramirez Luna wrote: > Now internal structures can remain hidden to the user and just API > related functions and defines are made available. > > Signed-off-by: Omar Ramirez Luna<omar.l...@linaro.org> > --- > drivers/mailbox/mailbox.c | 34 ++++++++++++++++++++++++++++++++ > drivers/mailbox/mailbox.h | 48 > +-------------------------------------------- > include/linux/mailbox.h | 22 +++++++++++++++++++ I agree with the file split but I think mailbox framework API should be more generic. omap_ prefix should not be used. mailbox_ prefix will be better. Message type must be more opened like for example: struct mailbox_msg { int size; unsigned char header; unsigned char *pdata; };
Regards, Loic-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/