On 11/06/2012 08:17 AM, Linus Walleij wrote:
> From: Linus Walleij <[email protected]>
>
> The fact that of_gpiochip_add_pin_range() and
> gpiochip_add_pin_range() share too much code is fragile and
> will invariably mean that bugs need to be fixed in two places
> instead of one.
>
> So separate the concerns of gpiolib.c and gpiolib-of.c and
> have the latter call the former as back-end. This is necessary
> also when going forward with other device descriptions such
> as ACPI.
> diff --git a/drivers/pinctrl/devicetree.c b/drivers/pinctrl/devicetree.c
> @@ -115,7 +114,6 @@ struct pinctrl_dev *of_pinctrl_add_gpio_range(struct
> device_node *np,
> if (!pctldev)
> return NULL;
>
> - pinctrl_add_gpio_range(pctldev, range);
> return pctldev;
> }
I think that collapses to just:
return pctldev;
Aside from that, the series,
Reviewed-by: Stephen Warren <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
