> We've had reports of this WARN against the Fedora kernel for a while. > Had this been immediately followed by a BUG(), we'd have never seen those > traces at all, > and just got "my machine just locked up" reports instead. > > The proper fix here is to find out why we're getting into this state.
Are you sure you don't mean the WARN below that ("recvmsg bug 2") instead? I don't think this one can happen without eventually running into the syslog overflow issue I described. I agree that the underlying cause must be fixed too, but as we will always have bugs in the kernel I think proper handling when it does happen is also important (and filling the hard disk with junk is obviously not the best approach). If you think a full panic is too extreme, I have an alternative version of this patch that logs the WARN once, closes the socket, and returns EBADFD from the syscall... would you think that is more appropriate? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/