On 11/07/2012 08:51 AM, Andrew Morton wrote: > On Tue, 23 Oct 2012 13:08:41 +0800 > Wei Yongjun <weiyj...@gmail.com> wrote: > >> From: Wei Yongjun <yongjun_...@trendmicro.com.cn> >> >> In case of error, the function test_init() need to call >> platform_device_del() instead of platform_device_unregister(). >> Otherwise, we may call platform_device_put() twice. >> > Is platform_device_del() the partner to platform_device_add()? If so > then yes, this looks right. But I think the labels can be improved: > > _ > > > However, take a look at test_exit(). it does > platform_device_unregister(test0) when test0 is in the same state. Is > that code wrong as well? Presumably it's working OK?
platform_device_unregister() is a warp of platform_device_del() and platform_device_put(), if platform_device_add() success, we can use platform_device_unregister() to do this, so that code is OK. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
