On Mon, Nov 12, 2012 at 11:03 PM, <snakky.zh...@gmail.com> wrote: > On 2012年11月13日 14:20, Yinghai Lu wrote: >>> 2012/11/13 6:17, Yinghai Lu wrote: >>>> >>>> + nr_range = 0; >>> >>> This is unnecessary since it is set in the below. >>> >>>> + nr_range = split_mem_range(mr, nr_range, start, end); >> >> ^^^^^^^^ > > Why not use 0 directly? > > nr_range = split_mem_range(mr, 0, start, end);
yes, even could remove nr_range from split_mem_range. but originally try to like "really" chopping the code to two parts. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/