On 11/04, Ananth N Mavinakayanahalli wrote: > > On Sat, Nov 03, 2012 at 05:33:01PM +0100, Oleg Nesterov wrote: > > > > [PATCH] uprobes: flush cache after xol write > > > > From: Rabin Vincent <[email protected]> > > > > Flush the cache so that the instructions written to the XOL area are > > visible. > > > > Signed-off-by: Rabin Vincent <[email protected]> > > Acked-by: Ananth N Mavinakayanahalli <[email protected]>
Thanks Ananth. I assume that Srikar and Rabin agree, applied as 65b6ecc038 > > > > --- x/kernel/events/uprobes.c > > +++ x/kernel/events/uprobes.c > > @@ -1199,6 +1199,11 @@ static unsigned long xol_get_insn_slot(s > > vaddr = kmap_atomic(area->page); > > memcpy(vaddr + offset, uprobe->arch.insn, MAX_UINSN_BYTES); > > kunmap_atomic(vaddr); > > + /* > > + * We probably need flush_icache_user_range() but it needs vma. > > + * This should work on supported architectures too. > > + */ > > + flush_dcache_page(area->page); > > > > return current->utask->xol_vaddr; > > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
