Hi Tejun On Thu, Nov 15, 2012 at 3:44 PM, Tejun Heo <[email protected]> wrote: > On Thu, Nov 15, 2012 at 01:23:17PM +0100, David Herrmann wrote: >> We do not check whether we already registered a CUSE device with a given >> name so we might end up with two devices with the same name. Sysfs will >> then complain as it cannot create suitable directories. >> >> This patch makes the init-command fail if there is already a device with >> the given name. To avoid race-conditions, we protect the whole >> registration with a mutex now. >> >> Following the sysfs warnings when registering two devices with the same >> name: > ... >> Signed-off-by: David Herrmann <[email protected]> > > Acked-by: Tejun Heo <[email protected]> > > But it probably would be better to separate out mutex conversion as a > separate patch.
Thanks for reviewing it again. I noticed the for-loop doesn't check all registered devices but only the devices in the same list-head. Luckily in my test-cases this was true. I will resend a v3 where I split this into two patches and correctly traverse the array and every list. Thanks David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
