On Fri, Nov 16, 2012 at 4:21 PM, Mika Westerberg <[email protected]> wrote: > On Fri, Nov 16, 2012 at 03:59:14PM +0200, Andy Shevchenko wrote: >> This function helps to distinguish the slave type of transfer by checking the >> direction parameter. >> >> Signed-off-by: Andy Shevchenko <[email protected]> >> Cc: Nicolas Ferre <[email protected]> >> Cc: Mika Westerberg <[email protected]> >> Cc: Guennadi Liakhovetski <[email protected]> >> Cc: Linus Walleij <[email protected]> >> --- >> include/linux/dmaengine.h | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h >> index 6402b18..3e1a9026 100644 >> --- a/include/linux/dmaengine.h >> +++ b/include/linux/dmaengine.h >> @@ -618,6 +618,11 @@ static inline int dmaengine_slave_config(struct >> dma_chan *chan, >> (unsigned long)config); >> } >> >> +static inline bool is_slave_xfer(enum dma_transfer_direction direction) >> +{ >> + return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM); >> +} > > I wonder if the above function need some prefix like > dmaengine_is_slave_xfer()?
is_dma_slave_xfer seems more consistent with other helper functions. But is_slave_xfer is vacant anyway. I like shorter names. > > Otherwise looks fine to me. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
