>From 21f1095ce30b21f1729c64eb26b7921bbb3bcc8d Mon Sep 17 00:00:00 2001 From: Constantine Shulyupin <[email protected]> Date: Sat, 17 Nov 2012 14:27:18 +0200 Subject: [PATCH v2] checkpatch: debugfs_remove() can take NULL
debugfs_remove() and debugfs_remove_recursive() can take a NULL, so let's check and warn about that. Channegs since v1: - added debugfs_remove_recursive - all tests for pattenrs are "if (a) xxx(a)" are consolidates Signed-off-by: Constantine Shulyupin <[email protected]> --- scripts/checkpatch.pl | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index f18750e..2339b54 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3213,21 +3213,29 @@ sub process { $herecurr); } -# check for needless kfree() checks +# check for needless "if" if ($prevline =~ /\bif\s*\(([^\)]*)\)/) { my $expr = $1; +# check for needless kfree() checks if ($line =~ /\bkfree\(\Q$expr\E\);/) { WARN("NEEDLESS_KFREE", "kfree(NULL) is safe this check is probably not required\n" . $hereprev); } - } # check for needless usb_free_urb() checks - if ($prevline =~ /\bif\s*\(([^\)]*)\)/) { - my $expr = $1; if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) { WARN("NEEDLESS_USB_FREE_URB", "usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev); } +# check for needless debugfs_remove() checks + if ($line =~ /\bdebugfs_remove\(\Q$expr\E\);/) { + WARN("NEEDLESS_DEBUGFS_REMOVE", + "debugfs_remove(NULL) is safe this check is probably not required\n" . $hereprev); + } +# check for needless debugfs_remove_recursive() checks + if ($line =~ /\bdebugfs_remove_recursive\(\Q$expr\E\);/) { + WARN("NEEDLESS_DEBUGFS_REMOVE", + "debugfs_remove_recursive(NULL) is safe this check is probably not required\n" . $hereprev); + } } # prefer usleep_range over udelay -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
