Le 20/11/2012 15:25, Dan Carpenter a écrit :
> On Tue, Nov 20, 2012 at 02:26:42PM +0100, MAACHE Mehdi wrote:
>> This is a patch to the r8180_wx.c file that fixes up some warnings and
>> errors found by the checkpatch.pl tool
>> - WARNING: line over 80 characters
>> - ERROR: "(foo*)" should be "(foo *)"
>> - ERROR: "foo* bar" should be "foo *bar"
>> - ERROR: trailing whitespace
>> - ERROR: that open brace { should be on the previous line
>>
>
> This needs to be broken into 4-5 separate patches and sent as
> series. One patch per warning type.
>
>> - if (erq->flags & IW_ENCODE_DISABLED)
>> -
>> - if (erq->length > 0) {
>> - u32* tkey = (u32*) key;
>> + if ((erq->flags & IW_ENCODE_DISABLED) && erq->length > 0) {
>> + u32 *tkey = (u32 *) key;
>
> Interesting... You have preserved the meaning of the original code,
> but actually the original code is buggy. Just delete the
> "if (erq->flags & IW_ENCODE_DISABLED)" check. This bug was
> introduced in de171bd6ff "Staging: rtl8187se: r8180_wx: fixed a lot
> of checkptahc.pl issues".
>
> Send that as a separate patch and mark it as a bugfix.
>
> regards,
> dan carpenter
>
Ok, I will do this. Thanks for the advice.
regards,
maache mehdi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
