On 22 November 2012 06:08, Greg KH <[email protected]> wrote: > On Thu, Nov 22, 2012 at 12:17:00AM +0100, Jiri Slaby wrote: >> On 11/22/2012 12:00 AM, Greg KH wrote: >> > On Wed, Nov 21, 2012 at 11:43:34PM +0100, Jiri Slaby wrote: >> >> On 11/21/2012 03:46 PM, Greg KH wrote: >> >>> On Wed, Nov 21, 2012 at 10:49:07AM +0530, Sachin Kamat wrote: >> >>>> --- a/drivers/tty/vt/consolemap.c >> >>>> +++ b/drivers/tty/vt/consolemap.c >> >>>> @@ -410,10 +410,8 @@ static void con_release_unimap(struct uni_pagedir >> >>>> *p) >> >>>> kfree(p->inverse_translations[i]); >> >>>> p->inverse_translations[i] = NULL; >> >>>> } >> >>>> - if (p->inverse_trans_unicode) { >> >>>> - kfree(p->inverse_trans_unicode); >> >>>> - p->inverse_trans_unicode = NULL; >> >>>> - } >> >>>> + kfree(p->inverse_trans_unicode); >> >>>> + p->inverse_trans_unicode = NULL; >> >>> >> >>> kfree with NULL is a no-op, but the line after that just caused a kernel >> >>> crash if it was NULL, so I can't accept this type of thing. >> >> >> >> Greg, I'm not sure -- what do you mean here? The change actually looks >> >> fine to me... We do not dereference p->inverse_trans_unicode there. >> > >> > If we never dereference it, why is it being set to NULL? >> >> I'm not disputing the assignment. Let it there. But I do not see any >> issues with the patch. What problem do you see exactly? > > {sigh} Nothing. I don't know what I was thinking, my apologies > Sachin, there's nothing wrong with this patch. > > I blame my fried brain, after reviewing all of those __dev* removal > patches :) > > Sachin, can you resend these patches so I can apply them?
No problem Greg. I will send them again. > > thanks, > > greg k-h -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
