Grant Likely writes:
>
> You mean this series wasn't created with a script? You did this by
> hand? If so then I must say kudos on your dedication!
>
> But it makes me more nervous about the series. Too easy to fat
> finger many things when touching that many files.
>
No, I didn't do them by hand, it was a script. Originally, it was a
couple, all basically the same, but removing each __dev*. Then I'd do
a word diff to eyeball them to make sure the script didn't do
something goofy.
The whack-a-mole part came along because I was working against
linux-next and whatever patch series was right for one day wouldn't be
right for the next day because of some of the faster moving trees.
> Please do write a script and post that for review.
>
The all-in-one version of the script:
#! /usr/bin/perl
use strict;
use IO::InSitu;
sub processfile
{
my $fn = shift;
my ($in, $out) = open_rw($fn, $fn);
while (<$in>) {
s|__devexit_p\(([^)]+)\)|$1|;
s|\s__devexit\b||;
s|\s__devinitconst\b||;
s|\s__devinitdata\b||;
s|\s__devinit\b||;
print $out $_;
}
close $in;
close $out;
}
foreach my $fn (@ARGV) {
processfile($fn);
}
--
Bill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
