On 11/22/2012 11:31 PM, Alexandre Pereira da Silva wrote: > Em 14/11/2012 09:58, "Alban Bedel" <[email protected]> escreveu: >> >> A single clock is used for all PWMs meaning the clock ref count might >> be between 0 and N when remove() is called. Instead of a single >> clk_disable() call pwm_disable() on each PWM, that ensure that >> clk_disable() is called for each PWM that were still enabled. >> >> Signed-off-by: Alban Bedel <[email protected]> > > Acked-by: Alexandre Pereira da Silva <[email protected]>
Some style fixes necessary below (Thierry will take care of it), otherwise: Acked-by: Roland Stigge <[email protected]> > >> --- >> drivers/pwm/pwm-lpc32xx.c | 5 ++++- >> 1 files changed, 4 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/pwm/pwm-lpc32xx.c b/drivers/pwm/pwm-lpc32xx.c >> index 03ec3ff..f45ce2c 100644 >> --- a/drivers/pwm/pwm-lpc32xx.c >> +++ b/drivers/pwm/pwm-lpc32xx.c >> @@ -136,8 +136,11 @@ static int lpc32xx_pwm_probe(struct platform_device > *pdev) >> static int __devexit lpc32xx_pwm_remove(struct platform_device *pdev) >> { >> struct lpc32xx_pwm_chip *lpc32xx = platform_get_drvdata(pdev); >> + int i; >> + >> + for (i = 0 ; i < lpc32xx->chip.npwm ; i += 1) >> + pwm_disable(&lpc32xx->chip.pwms[i]); >> >> - clk_disable(lpc32xx->clk); >> return pwmchip_remove(&lpc32xx->chip); >> } >> >> -- >> 1.7.0.4 >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
