On Tue, 04 Dec 2012 14:28:15 +0900 Jingoo Han <[email protected]> wrote:
> From: Marko Katic <[email protected]> > > Changing backlight intensity on an Akita (Sharp Zaurus C-1000) > triggers WARN_ON message: Well, I queued it up. > ... > > --- a/drivers/video/backlight/corgi_lcd.c > +++ b/drivers/video/backlight/corgi_lcd.c > @@ -408,11 +408,20 @@ static int corgi_bl_set_intensity(struct corgi_lcd > *lcd, int intensity) > /* Bit 5 via GPIO_BACKLIGHT_CONT */ > cont = !!(intensity & 0x20) ^ lcd->gpio_backlight_cont_inverted; > > - if (gpio_is_valid(lcd->gpio_backlight_cont)) > - gpio_set_value(lcd->gpio_backlight_cont, cont); > + if (gpio_is_valid(lcd->gpio_backlight_cont)) { > + if (gpio_cansleep(lcd->gpio_backlight_cont)) > + gpio_set_value_cansleep(lcd->gpio_backlight_cont, cont); > + else > + gpio_set_value(lcd->gpio_backlight_cont, cont); > + } But this looks utterly daft. Grant, these two things are the same - do we need both of them? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
