From: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com>
Subject: [PATCH] async_tx: fix checking of dma_wait_for_async_tx() return value

dma_wait_for_async_tx() can also return DMA_PAUSED (which
should be considered as error).

Cc: Vinod Koul <vinod.k...@intel.com>
Cc: Dan Williams <d...@fb.com>
Cc: Tomasz Figa <t.f...@samsung.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com>
---
 crypto/async_tx/async_tx.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Index: b/crypto/async_tx/async_tx.c
===================================================================
--- a/crypto/async_tx/async_tx.c        2012-11-07 16:30:47.940875970 +0100
+++ b/crypto/async_tx/async_tx.c        2012-11-07 16:31:34.888875965 +0100
@@ -128,8 +128,8 @@ async_tx_channel_switch(struct dma_async
                }
                device->device_issue_pending(chan);
        } else {
-               if (dma_wait_for_async_tx(depend_tx) == DMA_ERROR)
-                       panic("%s: DMA_ERROR waiting for depend_tx\n",
+               if (dma_wait_for_async_tx(depend_tx) != DMA_SUCCESS)
+                       panic("%s: DMA error waiting for depend_tx\n",
                              __func__);
                tx->tx_submit(tx);
        }
@@ -280,8 +280,9 @@ void async_tx_quiesce(struct dma_async_t
                 * we are referring to the correct operation
                 */
                BUG_ON(async_tx_test_ack(*tx));
-               if (dma_wait_for_async_tx(*tx) == DMA_ERROR)
-                       panic("DMA_ERROR waiting for transaction\n");
+               if (dma_wait_for_async_tx(*tx) != DMA_SUCCESS)
+                       panic("%s: DMA error waiting for transaction\n",
+                             __func__);
                async_tx_ack(*tx);
                *tx = NULL;
        }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to