On 12/5/2012 6:13 PM, Philip, Avinash wrote: > On Wed, Dec 05, 2012 at 17:33:37, Nori, Sekhar wrote: >> Hi Avinash, >> >> On 11/29/2012 5:16 PM, Philip, Avinash wrote: >>> Update number of errors using nand ecc strength. >>> Also add macro definitions BCH8_ERROR_MAX & BCH4_ERROR_MAX >> >> Can you please describe why the original method of setting nerrors was >> incorrect? Was it causing any issues in any particular configuration? > > It affects the reusability of the code. For example BCH8 with AM335x RBL > compatibility requires 14 bytes instead of 13 byte. So setting nerrors > with > nerrors = (info->nand.ecc.bytes == 13) ? 8 : 4; > will break am335x RBL compatibility.
This should be summarized in the patch description so the motivation is clear to those who read the history later. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
