On Dec 7, 2012, at 1:19 AM, Dan Carpenter wrote: > We should return NULL on failure instead of returning a freed pointer. > > Signed-off-by: Dan Carpenter <[email protected]> > > diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c > index e66ccbf..98f2965 100644 > --- a/drivers/block/aoe/aoedev.c > +++ b/drivers/block/aoe/aoedev.c > @@ -461,6 +461,7 @@ aoedev_by_aoeaddr(ulong maj, int min, int do_alloc) > d->targets = kcalloc(NTARGETS, sizeof(*d->targets), GFP_ATOMIC); > if (!d->targets) { > kfree(d); > + d = NULL; > goto out; > } > d->ntargets = NTARGETS;
That looks good, thanks. If smatch found that, then I have to figure out what I'm doing wrong, because I ran sparse and smatch on the latest patch series until they were clean. :/ -- Ed Cashin [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
