On Tue, Dec 11, 2012 at 12:07 AM, Grant Likely <[email protected]> wrote: > On Fri, 7 Dec 2012 16:01:39 +0200, Mathias Nyman > <[email protected]> wrote: >> Add gpio support for Intel Lynxpoint chipset. >> Lynxpoint supports 94 gpio pins which can generate interrupts. >> Driver will fail requests for pins that are marked as owned by ACPI, or >> set in an alternate mode (non-gpio). >> >> Signed-off-by: Mathias Nyman <[email protected]> >> --- >> +static void lp_gpio_set(struct gpio_chip *chip, unsigned gpio, int value) >> +{ >> + struct lp_gpio *lg = container_of(chip, struct lp_gpio, chip); >> + unsigned long reg = gpio_reg(chip, gpio, LP_CONFIG1); >> + unsigned long flags; >> + >> + spin_lock_irqsave(&lg->lock, flags); >> + >> + if (value) >> + outl(inl(reg) | OUT_LVL_BIT, reg); >> + else >> + outl(inl(reg) & ~OUT_LVL_BIT, reg); >> + >> + spin_unlock_irqrestore(&lg->lock, flags); >> +} > > A *lot* of drivers implement their own GPIO ops like this, and they all > end up looking the same. Please take a look at > drivers/gpio/gpio-generic.c and see if you can use the stock operations > provided there.
I was under the impression that the generic code could not be used off-the-shelf for drivers doing irqchips (like this one). But maybe I'm mistaken or it's trivial to fix? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
