On Thu, 29 Nov 2012 17:16:33 +0530, "Philip, Avinash" <avinashphi...@ti.com> 
wrote:
> The ELM hardware module can be used to speedup BCH 4/8/16 ECC scheme
> error correction.
> For now only 4 & 8 bit support is added
> 
> Signed-off-by: Philip, Avinash <avinashphi...@ti.com>
> Cc: Grant Likely <grant.lik...@secretlab.ca>
> Cc: Rob Herring <rob.herr...@calxeda.com>
> Cc: Rob Landley <r...@landley.net>
> ---
> Changes since v2:
>       - Remove __devinit & __devexit annotations
> 
> Changes since v1:
>       - Change build attribute to CONFIG_MTD_NAND_OMAP_BCH
>       - Reduced indentation using by passing elm_info , offset
>         to elm_read & elm_write
>       - Removed syndrome manipulation functions.
> 
> :000000 100644 0000000... b88ee83... A        
> Documentation/devicetree/bindings/mtd/elm.txt
> :100644 100644 395733a... 369a194... M        drivers/mtd/devices/Makefile
> :000000 100644 0000000... d2667f3... A        drivers/mtd/devices/elm.c
> :000000 100644 0000000... d4fce31... A        
> include/linux/platform_data/elm.h
>  Documentation/devicetree/bindings/mtd/elm.txt |   17 +
>  drivers/mtd/devices/Makefile                  |    4 +-
>  drivers/mtd/devices/elm.c                     |  418 
> +++++++++++++++++++++++++
>  include/linux/platform_data/elm.h             |   54 ++++
>  4 files changed, 493 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/elm.txt 
> b/Documentation/devicetree/bindings/mtd/elm.txt
> new file mode 100644
> index 0000000..b88ee83
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/elm.txt
> @@ -0,0 +1,17 @@
> +Error location module
> +
> +Required properties:
> +- compatible: Must be "ti,elm"

Compatible string is too generic. Need to specify a specific SoC here.
ie: "ti,omap3430-elm"

Otherwise the binding looks fine. I haven't reviewed the code though.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to