On Tue, 2012-12-18 at 14:59 +0530, Durgadoss R wrote: > This patch creates sensor level APIs, in the > generic thermal framework.
Just some trivial notes. > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c [] > +static ssize_t > +sensor_temp_show(struct device *dev, struct device_attribute *attr, char > *buf) > +{ > + int ret; > + long val; > + struct thermal_sensor *ts = to_thermal_sensor(dev); > + > + ret = ts->ops->get_temp(ts, &val); > + > + return ret ? ret : sprintf(buf, "%ld\n", val); I'd much prefer the form ret = ts->ops... if (ret) return ret; return sprintf(buf, "%ld\n", val); Otherwise, maybe use gcc's pretty common ?: extension return ret ?: sprintf(...) [] > +static int enable_sensor_thresholds(struct thermal_sensor *ts, int count) > +{ > + int i; > + int size = sizeof(struct thermal_attr) * count; > + > + ts->thresh_attrs = kzalloc(size, GFP_KERNEL); kcalloc > + if (!ts->thresh_attrs) > + return -ENOMEM; > + > + if (ts->ops->get_hyst) { > + ts->hyst_attrs = kzalloc(size, GFP_KERNEL); kcalloc here too -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/