Ravishankar N <cybera...@gmail.com> writes: > /* > - * Return values: negative -> error, 0 -> not found, positive -> found, > - * value is the total amount of slots, including the shortname entry. > + * Return values: negative -> error/not found, 0 -> found. > */ > int fat_search_long(struct inode *inode, const unsigned char *name, > int name_len, struct fat_slot_info *sinfo) > @@ -1176,7 +1175,7 @@ static int fat_add_new_entries(struct inode *dir, void > *slots, int nr_slots, > > /* > * The minimum cluster size is 512bytes, and maximum entry > - * size is 32*slots (672bytes). So, iff the cluster size is > + * size is 32*slots (672bytes). So, if the cluster size is
iff is right here. iff == if and only if > -// fat_cache_add(inode, new_fclus, new_dclus); I guess this still worth to keep as FIXME. This meant the following. /* * FIXME: Although we can add this cache, fat_cache_add() is assuming to * be called after liner search with fat_cache_id. */ > } else { > MSDOS_I(inode)->i_start = new_dclus; > MSDOS_I(inode)->i_logstart = new_dclus; Other parts looks fine. Thanks. -- OGAWA Hirofumi <hirof...@mail.parknet.co.jp> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/