On Wed, 2012-12-19 at 16:21 +0000, Grant Likely wrote: > On Wed, 19 Dec 2012 09:04:16 +0000, Mark Brown > <broo...@opensource.wolfsonmicro.com> wrote: > > On Wed, Dec 19, 2012 at 04:44:03AM -0500, Jun Chen wrote: > > > > > This spi_alloc_device function will be called in the spi_new_device > > > function to alloc new device as the master. But other way, it is called > > > by the of_register_spi_devices function to register new device as the > > > children of the master. I will update changlog to add it. > > > > But why is this a bad thing? You've said what's happening but not why > > it's a problem. > > spi_devices should always be children of the spi_master. If that is not > the case then it is a bug to be fixed. >
When many boards initializing, boards will call function spi_register_board_info to create bi->board_info,Then spi driver probe to call spi_register_master to register the driver and in the function spi_match_master_to_boardinfo To create new spi device, and this cases the spi_devices are not children of the spi_master. Many drivers do these steps. If all spi_devices must be children of the spi_master, Do spi core have plan to delete this way? Or spi core can hold this way for many drivers. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
