>-----Original Message----- >From: David Rientjes [mailto:[email protected]] >Sent: Friday, December 28, 2012 6:39 AM >To: Liu Hui-R64343 >Cc: Mel Gorman; [email protected] >Subject: Re: echo 1 > /proc/sys/vm/compact_memory -> sh: write error: Bad >address > >On Thu, 27 Dec 2012, Liu Hui-R64343 wrote: > >> diff --git a/mm/compaction.c b/mm/compaction.c index c4bc5ac..d3cb27f >> 100644 >> --- a/mm/compaction.c >> +++ b/mm/compaction.c >> @@ -732,8 +732,10 @@ int sysctl_compact_memory; int >> sysctl_compaction_handler(struct ctl_table *table, int write, >> void __user *buffer, size_t *length, loff_t >> *ppos) { >> - if (write) >> - return compact_nodes(); >> + if (write) { >> + compact_nodes(); >> + return *length; >> + } >> >> return 0; >> } > >No need to return the length at all, simply change compact_nodes() to return >void, remove the return value, and do > > if (write) > compact_nodes(); > return 0; > >and it should be fixed.
Yes, this works. Thanks, > Could you write a changelog that shows the before >and after behavior (not necessarily the implementation), sign-off the patch >as described in Documentation/SubmittingPatches, running >scripts/get_maintainer.pl on your new patch file, and sending it to all >addresses that are listed? OK, I will send out the patch as you suggested. Happy holiday. Jason Liu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
