On Thursday 10 January 2013 04:27 PM, Linus Walleij wrote:
On Thu, Jan 3, 2013 at 11:46 AM, Laxman Dewangan <[email protected]> wrote:
Add gpio driver for TI Palmas series PMIC. This has 8 gpio which can
work as input/output.
Signed-off-by: Laxman Dewangan <[email protected]>
This driver seems unnecessary. Can't you just use
drivers/gpio/gpio-generic.c ?
The gpio-generic driver is for the MMIO based interface. This is for the
PMIC-Palma which is in i2c interface and so need to have register access
through the i2c call exposed by palma mfd driver.
+static int palmas_gpio_to_irq(struct gpio_chip *gc, unsigned offset)
+{
+ struct palmas_gpio *pg = to_palmas_gpio(gc);
+ struct palmas *palmas = pg->palmas;
+
+ return palmas_irq_get_virq(palmas, PALMAS_GPIO_0_IRQ + offset);
+}
Why are you implementing this for a driver which does not even expose
the ability to trigger IRQs? If it's supposed to support IRQs it should
register a struct irq_chip.
The interrupts are registered in mfd core via the regmap-irq_chip.
This api converts the gpio number to corresponding irq.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
