The C standards allows the character type char to be singed or unsinged, depending on the platform and compiler. Most of systems uses signed char, but those based on PowerPC and ARM processors typically use unsigned char. This can lead to unexpected results when the variable is used to compare with EOF(-1). It happens my ARM system and this patch fixes it.
Cc: Mel Gorman <[email protected]> Cc: Andy Whitcroft <[email protected]> Cc: Alexander Nyberg <[email protected]> Cc: Michal Nazarewicz <[email protected]> Cc: Randy Dunlap <[email protected]> Signed-off-by: Minchan Kim <[email protected]> --- Documentation/page_owner.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/page_owner.c b/Documentation/page_owner.c index f0156e1..43dde96 100644 --- a/Documentation/page_owner.c +++ b/Documentation/page_owner.c @@ -32,12 +32,13 @@ int read_block(char *buf, FILE *fin) { int ret = 0; int hit = 0; + int val; char *curr = buf; for (;;) { - *curr = getc(fin); - if (*curr == EOF) return -1; - + val = getc(fin); + if (val == EOF) return -1; + *curr = val; ret++; if (*curr == '\n' && hit == 1) return ret - 1; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
