On Sun, Jan 20, 2013 at 03:42:28PM -0800, Greg KH wrote:
> On Sat, Jan 19, 2013 at 02:02:22AM -0700, Jon Mason wrote:
> > Tag pci_device_id in ntb_pci_probe as unused function parameters. This
> > corrects issues found by 'EXTRA_CFLAGS=-W'.
>
> Why would you build the kernel with that option? This isn't needed, so
Per Documentation/SubmitChecklist:
22: Newly-added code has been compiled with `gcc -W' (use "make
EXTRA_CFLAGS=-W"). This will generate lots of noise, but is good for
finding bugs like "warning: comparison between signed and unsigned".
I was attempting to comply with that suggestion. If this is
unnecessary, then I can toss these, but I don't really see them
hurting anything.
Same goes for the other 2 patches found via 'EXTRA_CFLAGS=-W'.
Thanks,
Jon
> I'm not going to apply it.
>
> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
