On Friday 25 January 2013 15:25:03 Peter Ujfalusi wrote: > On 01/25/2013 03:14 PM, Arnd Bergmann wrote: > > If the twl4030_write_script function gets called with > > a zero length argument, its return value does not > > get set. We know that all scripts have a nonzero > > length, but returning an error in case they ever > > do is probably appropriate. > > > > Without this patch, building omap2plus_defconfig results in: > > > > drivers/mfd/twl4030-power.c: In function 'load_twl4030_script': > > drivers/mfd/twl4030-power.c:414:5: error: 'err' may be used uninitialized > > in this function > > I've fixed up Kevin's email since he is no longer with TI and added Tero to > the CC list since this is *something*-power on OMAP platforms > > Reviewed-by: Peter Ujfalusi <peter.ujfal...@ti.com>
Thanks! I also got the mailing list address wrong on all mails, so I'll retransmit the whole series in a bit, just waiting for other quick comments to come in. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/