On Thu, 24 Jan 2013, Simon Wood wrote: > From: simon <simon@simon-virtual-machine.(none)> > > This patch to the SRW-S1 driver adds the ability to control all > LEDs simultaneously as testing showed that it was slow (noticably!!) > when seting or clearing all the LEDs in turn. > > It adds a 'RPMALL' LED, whose behavoir is asserted to all the LEDs in > the bar graph, individual LEDs can subsequently be turned on/off > individually. > > Signed-off-by: Simon Wood <[email protected]> > tested-by: John Murphy <[email protected]> [ ... snip ... ]
> @@ -219,13 +255,34 @@ static int srws1_probe(struct hid_device *hdev, > > /* register led subsystem */ > drv_data->led_state = 0; > - for (i = 0; i < SRWS1_NUMBER_LEDS; i++) > + for (i = 0; i < SRWS1_NUMBER_LEDS + 1; i++) > drv_data->led[i] = NULL; > > srws1_set_leds(hdev, 0); > > - name_sz = strlen(hdev->uniq) + 15; > + name_sz = strlen(hdev->uniq) + 16; > + > + /* 'ALL', for setting all LEDs simultaneously */ > + led = kzalloc(sizeof(struct led_classdev)+name_sz, GFP_KERNEL); Is this memory ever freed? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
