On Thu, Jan 31, 2013 at 01:54:37PM +0100, Stephane Eranian wrote: > > The __perf_evlist__set_leader() was setting the leader for all events > in the list except the first. Which means it assumed the first event > already had event->leader = event. Seems like this should be the role > of the function to also do this. This is a requirement for an upcoming > patch set.
agreed, Acked/Tested-by Jiri Olsa <[email protected]> > > Signed-off-by: Stephane Eranian <[email protected]> > --- > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > index dc8aee9..050d5bc 100644 > --- a/tools/perf/util/evlist.c > +++ b/tools/perf/util/evlist.c > @@ -119,8 +119,7 @@ void __perf_evlist__set_leader(struct list_head *list) > leader = list_entry(list->next, struct perf_evsel, node); > > list_for_each_entry(evsel, list, node) { > - if (evsel != leader) > - evsel->leader = leader; > + evsel->leader = leader; > } that's leftover from the times when leader has 'leader' set to NULL we made the change here: perf evsel: Set leader evsel's ->leader to itself commit 2cfda562da7b0b1e0575507ef3efe782d4e218e4 Author: Namhyung Kim <[email protected]> Date: Thu Nov 29 15:38:29 2012 +0900 the leader is set properly in perf_evsel__init and when reading perf.data, so there was no harm in current code thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
