Waiting for a pending hangup to complete is not a necessary post-operation of using tty_ldisc_halt() and not sufficient to guarantee a hangup is not in-progress. As far as the ldisc layer is concerned, waiting for a pending hangup is necessary only prior to changing the ldisc while handling the TIOCSETD ioctl (and only because the tty lock must be released as a precondition of halting the ldisc).
Signed-off-by: Peter Hurley <pe...@hurleysoftware.com> --- drivers/tty/tty_ldisc.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index 9599b05..f3cbfb3 100644 --- a/drivers/tty/tty_ldisc.c +++ b/drivers/tty/tty_ldisc.c @@ -538,10 +538,6 @@ static int tty_ldisc_wait_idle(struct tty_struct *tty, long timeout) * * Callers other than tty_ldisc_release() must hold ->ldisc_mutex and * cannot be holding tty_lock() (aka legacy_mutex). - * - * You need to do a 'flush_scheduled_work()' (outside the ldisc_mutex) - * in order to make sure any currently executing ldisc work is also - * flushed. */ static int tty_ldisc_halt(struct tty_struct *tty, struct tty_struct *o_tty, -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
