>>> On 06.02.13 at 18:12, Konrad Rzeszutek Wilk <[email protected]> wrote: >> + if (pci_find_capability(dev, PCI_CAP_ID_MSIX)) { >> + struct physdev_pci_device ppdev = { >> + .seg = pci_domain_nr(dev->bus), >> + .bus = dev->bus->number, >> + .devfn = dev->devfn >> + }; >> + int err = HYPERVISOR_physdev_op(PHYSDEVOP_release_msix, >> + &ppdev); >> + >> + if (err) >> + dev_warn(&dev->dev, "MSI-X release failed (%d)\n", >> + err); >> + } > > Perhaps it should be more off: > > if (err) { > if (err == -ENOSYS) > dev_info(&dev->dev,"MSI-X release > hypercall not supported."); > else > dev_warn(&dev->dev, "MSI-X release failed > (%d)\n", > err); >
Why would you want to special case this? The more that _really_ old hypervisors returned -EINVAL instead of -ENOSYS here? Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
