Tim Gardner <[email protected]> writes: > befs_sb->num_blocks is of base type u64 which is the same as sector_t. > Therefore, num_blocks can never be larger then the maximum > value of sector_t.
The analysys is wrong. On 32bit with CONFIG_LBAF unset sector_t is an unsigned long aka a u32, while befs_off_t is always a u64. Nacked-by: "Eric W. Biederman" <[email protected]> > smatch analysis: > > fs/befs/linuxvfs.c:851 befs_fill_super() warn: impossible > condition '(befs_sb->num_blocks > ~(0)) => (0-u64max > u64max)' > > Cc: Al Viro <[email protected]> > Cc: Andrew Morton <[email protected]> > Cc: "Eric W. Biederman" <[email protected]> > Cc: "Kirill A. Shutemov" <[email protected]> > Signed-off-by: Tim Gardner <[email protected]> > --- > fs/befs/linuxvfs.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c > index 2b3bda8..2ce5705 100644 > --- a/fs/befs/linuxvfs.c > +++ b/fs/befs/linuxvfs.c > @@ -848,13 +848,6 @@ befs_fill_super(struct super_block *sb, void *data, int > silent) > if (befs_check_sb(sb) != BEFS_OK) > goto unacquire_priv_sbp; > > - if( befs_sb->num_blocks > ~((sector_t)0) ) { > - befs_error(sb, "blocks count: %Lu " > - "is larger than the host can use", > - befs_sb->num_blocks); > - goto unacquire_priv_sbp; > - } > - > /* > * set up enough so that it can read an inode > * Fill in kernel superblock fields from private sb -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
