On 2013-02-12 10:56:54, Tim Gardner wrote:
> smatch analysis:
> 
> fs/ecryptfs/keystore.c:1206 decrypt_pki_encrypted_session_key() info:
>  redundant null check on msg calling kfree()
> 
> Cc: Tyler Hicks <[email protected]>
> Cc: Dustin Kirkland <[email protected]>
> Cc: [email protected]
> Signed-off-by: Tim Gardner <[email protected]>

Thanks, Tim. Pushed to the next branch at
git://git.kernel.org/pub/scm/linux/kernel/git/tyhicks/ecryptfs.git

Tyler

> ---
>  fs/ecryptfs/keystore.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c
> index 6154cde..5aceff2 100644
> --- a/fs/ecryptfs/keystore.c
> +++ b/fs/ecryptfs/keystore.c
> @@ -1202,8 +1202,7 @@ decrypt_pki_encrypted_session_key(struct 
> ecryptfs_auth_tok *auth_tok,
>                                 crypt_stat->key_size);
>       }
>  out:
> -     if (msg)
> -             kfree(msg);
> +     kfree(msg);
>       return rc;
>  }
>  
> -- 
> 1.7.9.5
> 

Attachment: signature.asc
Description: Digital signature

Reply via email to