smatch analysis:

fs/hugetlbfs/inode.c:883 hugetlbfs_fill_super() info: redundant null check on 
sbinfo->spool calling kfree()

Cc: Nadia Yvette Chambers <n...@holomorphy.com>
Signed-off-by: Tim Gardner <tim.gard...@canonical.com>
---
 fs/hugetlbfs/inode.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index 78bde32..e2e36ef 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -879,8 +879,7 @@ hugetlbfs_fill_super(struct super_block *sb, void *data, 
int silent)
                goto out_free;
        return 0;
 out_free:
-       if (sbinfo->spool)
-               kfree(sbinfo->spool);
+       kfree(sbinfo->spool);
        kfree(sbinfo);
        return -ENOMEM;
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to