> -----Original Message-----
> From: [email protected] [mailto:linux-kernel-
> [email protected]] On Behalf Of Jingoo Han
> Sent: Friday, February 15, 2013 11:29 AM
> To: 'Andrew Morton'
> Cc: [email protected]; 'Alessandro Zummo'; rtc-
> [email protected]; 'Jingoo Han'
> Subject: [PATCH 03/11] rtc: rtc-efi: use pr_err()/pr_warn() instead of
> printk()
>
> Fixed the checkpatch warnings as below:
>
> WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...
> to printk(KERN_ERR ...
> WARNING: please, no space before tabs
>
> Signed-off-by: Jingoo Han <[email protected]>
> ---
> drivers/rtc/rtc-efi.c | 10 ++++++----
> 1 files changed, 6 insertions(+), 4 deletions(-)
>
> eft->timezone = EFI_UNSPECIFIED_TIMEZONE;
> @@ -142,7 +144,7 @@ static int efi_set_alarm(struct device *dev, struct
> rtc_wkalrm *wkalrm)
> */
> status = efi.set_wakeup_time((efi_bool_t)wkalrm->enabled, &eft);
>
> - printk(KERN_WARNING "write status is %d\n", (int)status);
> + pr_warn("write status is %d\n", (int)status);
Why don't you use dev_warn itself?
>
> return status == EFI_SUCCESS ? 0 : -EINVAL;
> }
> @@ -157,7 +159,7 @@ static int efi_read_time(struct device *dev, struct
> rtc_time *tm)
>
> if (status != EFI_SUCCESS) {
> /* should never happen */
> - printk(KERN_ERR "efitime: can't read time\n");
> + pr_err("can't read time\n");
Why don't you use dev_err itself?
> return -EINVAL;
> }
>
> --
> 1.7.2.5
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
