Date: Mon, 18 Feb 2013 14:24:36 -0700 From: Tim Gardner <[email protected]>
'firewire: convert to idr_alloc()' accidentally orphaned 'minor'. drivers/firewire/core-device.c: In function ‘fw_device_init’: drivers/firewire/core-device.c:1029:24: warning: ‘minor’ may be used uninitialized in this function [-Wuninitialized] Signed-off-by: Tim Gardner <[email protected]> Signed-off-by: Stefan Richter <[email protected]> --- Andrew, please send this on together with the other idr patches, or even merge this into patch "firewire: convert to idr_alloc()" before the latter reaches upstream. drivers/firewire/core-device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/firewire/core-device.c b/drivers/firewire/core-device.c index b946330..03ce7d9 100644 --- a/drivers/firewire/core-device.c +++ b/drivers/firewire/core-device.c @@ -1017,10 +1017,11 @@ static void fw_device_init(struct work_struct *work) fw_device_get(device); down_write(&fw_device_rwsem); - ret = idr_alloc(&fw_device_idr, device, 0, 1 << MINORBITS, GFP_KERNEL); + minor = idr_alloc(&fw_device_idr, device, 0, 1 << MINORBITS, + GFP_KERNEL); up_write(&fw_device_rwsem); - if (ret < 0) + if (minor < 0) goto error; device->device.bus = &fw_bus_type; -- Stefan Richter -=====-===-= --=- =--== http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
