On Tue, Feb 19, 2013 at 09:53:47AM -0800, H. Peter Anvin wrote: > On 02/19/2013 01:31 AM, Cyrill Gorcunov wrote: > >+ > >+ If unsure, say N. > >+ > > Wrong advice. In this particular case, Y is the safe alternative. --- From: Cyrill Gorcunov <gorcu...@openvz.org> Subject: kcmp: Make it to depend on CONFIG_KCMP
Since kcmp syscall has been implemented (initially on x86 architecture) a number of other archs wire it up as well: xtensa, sparc, sh, s390, mips, microblaze, m68k (not taking into account those who uses <asm-generic/unistd.h> for syscall numbers definitions). But the Makefile, which turns kcmp.o generation on still depends on former config-x86. Thus get rid of this limitation and make kcmp.o depend on CONFIG_KCMP option. v2: - As Michal pointed the old configs might already use of CHECKPOINT_RESTORE, so make "default" accordingly. - Advice Y if unsure Signed-off-by: Cyrill Gorcunov <gorcu...@openvz.org> Cc: KOSAKI Motohiro <kosaki.motoh...@gmail.com> Cc: "Eric W. Biederman" <ebied...@xmission.com> Cc: Pavel Emelyanov <xe...@parallels.com> Cc: Andrey Vagin <ava...@openvz.org> Cc: Ingo Molnar <mi...@elte.hu> Cc: H. Peter Anvin <h...@zytor.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Glauber Costa <glom...@parallels.com> Cc: Andi Kleen <a...@firstfloor.org> Cc: Tejun Heo <t...@kernel.org> Cc: Matt Helsley <matth...@us.ibm.com> Cc: Pekka Enberg <penb...@kernel.org> Cc: Eric Dumazet <eric.duma...@gmail.com> Cc: Vasiliy Kulikov <seg...@openwall.com> Cc: Alexey Dobriyan <adobri...@gmail.com> Cc: valdis.kletni...@vt.edu Cc: Michal Marek <mma...@suse.cz> Cc: Frederic Weisbecker <fweis...@gmail.com> Cc: Andrew Morton <a...@linux-foundation.org> --- init/Kconfig | 9 +++++++++ kernel/Makefile | 4 +--- 2 files changed, 10 insertions(+), 3 deletions(-) Index: linux-2.6.git/init/Kconfig =================================================================== --- linux-2.6.git.orig/init/Kconfig +++ linux-2.6.git/init/Kconfig @@ -279,6 +279,15 @@ config FHANDLE get renamed. Enables open_by_handle_at(2) and name_to_handle_at(2) syscalls. +config KCMP + bool "kcmp syscall" + default CHECKPOINT_RESTORE + help + If you say Y here, a user level program will be able to use + kcmp(2) syscall. + + If unsure, say Y. + config AUDIT bool "Auditing support" depends on NET Index: linux-2.6.git/kernel/Makefile =================================================================== --- linux-2.6.git.orig/kernel/Makefile +++ linux-2.6.git/kernel/Makefile @@ -25,9 +25,7 @@ endif obj-y += sched/ obj-y += power/ -ifeq ($(CONFIG_CHECKPOINT_RESTORE),y) -obj-$(CONFIG_X86) += kcmp.o -endif +obj-$(CONFIG_KCMP) += kcmp.o obj-$(CONFIG_FREEZER) += freezer.o obj-$(CONFIG_PROFILING) += profile.o obj-$(CONFIG_STACKTRACE) += stacktrace.o -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/