Getting the brightness value is not critical, no need to read the actual register value. To simplify it, just return the 'bl->props.brightness' value. Then, lp855x_read_byte() can be removed, not used any more.
Signed-off-by: Milo(Woogyom) Kim <[email protected]> --- drivers/video/backlight/lp855x_bl.c | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c index edd2041..7ae9ae6 100644 --- a/drivers/video/backlight/lp855x_bl.c +++ b/drivers/video/backlight/lp855x_bl.c @@ -66,20 +66,6 @@ struct lp855x { struct pwm_device *pwm; }; -static int lp855x_read_byte(struct lp855x *lp, u8 reg, u8 *data) -{ - int ret; - - ret = i2c_smbus_read_byte_data(lp->client, reg); - if (ret < 0) { - dev_err(lp->dev, "failed to read 0x%.2x\n", reg); - return ret; - } - - *data = (u8)ret; - return 0; -} - static int lp855x_write_byte(struct lp855x *lp, u8 reg, u8 data) { return i2c_smbus_write_byte_data(lp->client, reg, data); @@ -274,16 +260,6 @@ static int lp855x_bl_update_status(struct backlight_device *bl) static int lp855x_bl_get_brightness(struct backlight_device *bl) { - struct lp855x *lp = bl_get_data(bl); - enum lp855x_brightness_ctrl_mode mode = lp->pdata->mode; - - if (mode == REGISTER_BASED) { - u8 val = 0; - - lp855x_read_byte(lp, lp->cfg->reg_brightness, &val); - bl->props.brightness = val; - } - return bl->props.brightness; } -- 1.7.9.5 Best Regards, Milo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
