On Friday 01 March 2013 06:13 PM, Mark Brown wrote:
* PGP Signed by an unknown key

On Fri, Mar 01, 2013 at 06:04:56PM +0530, Laxman Dewangan wrote:

Currently driver sets the irq type to IRQF_TRIGGER_LOW which is
causing interrupt registration failure in ARM based SoCs as:
[    0.208479] genirq: Setting trigger mode 8 for irq 118 failed 
(gic_set_type+0x0/0xf0)
[    0.208513] dummy 0-0059: Failed to request IRQ 118: -22
This can't be a generic problem on ARM systems, I'm pretty sure the
primary users of palmas would've noticed, this is more of a new feature
isn't it?

I think it is tested with eval board and connected to gpio interrupt and hence it is not noticed.



+       if (ret < 0) {
+               dev_err(palmas->dev, "POLARITY_CTRL write failed: %d\n", ret);
+               goto err;
+       }
Isn't there a read/modify/write call for palmas?

Yaah, there is call but forget as I took this fix from my downstream code.
I will respin the next patch.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to