On 03/05/13 22:03, Venu Byravarasu wrote: > >> +/** >> + * devm_rtc_device_register - resource managed rtc_device_register() >> + * @name: the name of the device >> + * @dev: the device to register >> + * @ops: the rtc operations structure >> + * @owner: the module owner >> + * >> + * @return a struct rtc on success, or an ERR_PTR on error >> + * >> + * Managed rtc_device_register(). The rtc_device returned from this >> function >> + * are automatically freed on driver detach. See rtc_device_register() >> + * for more information. >> + */ >> + >> +struct rtc_device *devm_rtc_device_register(const char *name, >> + struct device *dev, > As most of devm_* functions use " struct device *dev" as their first param, > why not this function also modified to be in sync with them?
I suspect it's because the signature matches rtc_device_register(). This way you can do a simple search and replace and avoid having to reorder arguments. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
