From: Joe Perches <[email protected]> Date: Wed, 06 Mar 2013 16:07:17 -0800
> On Wed, 2013-03-06 at 23:48 +0200, Silviu-Mihai Popescu wrote: >> This lines up function arguments on second and subsequent lines at the >> first column after the openning parenthesis of the first line. > [] >> diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c > [] >> @@ -301,10 +301,10 @@ static void dev_flowctrl(struct net_device *dev, int >> on) >> } >> >> void caif_enroll_dev(struct net_device *dev, struct caif_dev_common >> *caifdev, >> - struct cflayer *link_support, int head_room, >> - struct cflayer **layer, int (**rcv_func)( >> - struct sk_buff *, struct net_device *, >> - struct packet_type *, struct net_device *)) >> + struct cflayer *link_support, int head_room, >> + struct cflayer **layer, int (**rcv_func)( >> + struct sk_buff *, struct net_device *, >> + struct packet_type *, struct net_device *)) > > This makes it seem that caif_enroll_dev takes more args. > > I think this style is better (aligned to appropriate open paren) > > void caif_enroll_dev(struct net_device *dev, struct caif_dev_common *caifdev, > struct cflayer *link_support, int head_room, > struct cflayer **layer, > int (**rcv_func)(struct sk_buff *, struct net_device *, > struct packet_type *, struct net_device > *)) Agreed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
