Steven, (03/08/2013 12:34 AM), Steven Rostedt wrote:
The second patch, returns success on a reset of the buffer even if the buffer wasn't allocated. Returning -EINVAL is just confusing.
I realized we should update the snapshot documentation together with this change. I attached a patch to update the documentation. Could you include this patch? Thanks, Hiraku Toyooka From: Hiraku Toyooka <hiraku.toyooka...@hitachi.com> Subject: [PATCH] tracing: update documentation of snapshot utility Now, "snapshot" file returns success on a reset of snapshot buffer even if the buffer wasn't allocated, instead of returning EINVAL. This patch updates snapshot desctiption according to the change. Signed-off-by: Hiraku Toyooka <hiraku.toyooka...@hitachi.com> --- Documentation/trace/ftrace.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/trace/ftrace.txt b/Documentation/trace/ftrace.txt index 53d6a3c..a372304 100644 --- a/Documentation/trace/ftrace.txt +++ b/Documentation/trace/ftrace.txt @@ -1873,7 +1873,7 @@ feature: status\input | 0 | 1 | else | --------------+------------+------------+------------+ - not allocated |(do nothing)| alloc+swap | EINVAL | + not allocated |(do nothing)| alloc+swap |(do nothing)| --------------+------------+------------+------------+ allocated | free | swap | clear | --------------+------------+------------+------------+ -- 1.7.11.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/