This is Jason's code. Jason, please give an Ack or Nack.
Thanks, -- Steve On Mon, 2013-03-11 at 15:13 +0800, zhangwei(Jovi) wrote: > trace_empty is checking in while-loop, so the previous checking > is totally redundant, and more worse, the first trace entry is losted. > > so remove it. > > Signed-off-by: zhangwei(Jovi) <[email protected]> > --- > kernel/trace/trace_kdb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/trace/trace_kdb.c b/kernel/trace/trace_kdb.c > index 3c5c5df..6489b2e 100644 > --- a/kernel/trace/trace_kdb.c > +++ b/kernel/trace/trace_kdb.c > @@ -57,8 +57,7 @@ static void ftrace_dump_buf(int skip_lines, long cpu_file) > ring_buffer_read_start(iter.buffer_iter[cpu_file]); > tracing_iter_reset(&iter, cpu_file); > } > - if (!trace_empty(&iter)) > - trace_find_next_entry_inc(&iter); > + > while (!trace_empty(&iter)) { > if (!cnt) > kdb_printf("---------------------------------\n"); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
