Hi Wei, Thank you for the patch.
On Monday 11 March 2013 22:08:12 Wei Yongjun wrote: > From: Wei Yongjun <[email protected]> > > In case of error, the function pinctrl_register() returns > NULL not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL test. > > Signed-off-by: Wei Yongjun <[email protected]> Acked-by: Laurent Pinchart <[email protected]> I've taken the patch in my tree and will push it to v3.10. > --- > drivers/pinctrl/sh-pfc/pinctrl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/sh-pfc/pinctrl.c > b/drivers/pinctrl/sh-pfc/pinctrl.c index 11e0e13..271e2c1 100644 > --- a/drivers/pinctrl/sh-pfc/pinctrl.c > +++ b/drivers/pinctrl/sh-pfc/pinctrl.c > @@ -439,8 +439,8 @@ int sh_pfc_register_pinctrl(struct sh_pfc *pfc) > return ret; > > pmx->pctl = pinctrl_register(&sh_pfc_pinctrl_desc, pfc->dev, pmx); > - if (IS_ERR(pmx->pctl)) > - return PTR_ERR(pmx->pctl); > + if (!pmx->pctl) > + return -EINVAL; > > sh_pfc_gpio_range.npins = pfc->info->last_gpio > - pfc->info->first_gpio + 1; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
