(2013/03/13 1:04), Linus Torvalds wrote: > On Mon, Mar 11, 2013 at 7:22 AM, Masami Hiramatsu > <[email protected]> wrote: >> Beacuse hash_64() is called from the get_kprobe() inside >> int3 handler, kernel causes int3 recursion and crashes if >> kprobes user puts a probe on it. >> >> Usually hash_64() is inlined into caller function, but in >> some cases, it has instances by gcc's interprocedural >> constant propagation. >> >> This patch adds __kprobes tag on the hash_64() > > NAK. Don't do this. Just force inlining. There's absolutely no way we > want to start adding __kprobe to random helper functions like this.
I see. > This isn't even about where "__kprobes" exists and whether we want to > include the header file. This is about the fact that hash64 has > absolutely *nothing* to do with kprobes, and we simply shouldn't do > crap like this regardless of whether we need a new #include or not. OK, then I'll update it to just use __always_inline. Thank you! -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
