On Sat, Mar 16, 2013 at 02:02:36PM +0200, Silviu-Mihai Popescu wrote: > The objects allocated by devm_* APIs are managed by devres and are freed > when the device is detached. There is no need to use kfree() explicitly.
Not only 'no need', it's simply wrong. > > Signed-off-by: Silviu-Mihai Popescu <[email protected]> Acked-by: Sascha Hauer <[email protected]> Sascha > --- > drivers/staging/imx-drm/ipu-v3/ipu-dp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dp.c > b/drivers/staging/imx-drm/ipu-v3/ipu-dp.c > index 26aecaf..113b046 100644 > --- a/drivers/staging/imx-drm/ipu-v3/ipu-dp.c > +++ b/drivers/staging/imx-drm/ipu-v3/ipu-dp.c > @@ -316,7 +316,6 @@ int ipu_dp_init(struct ipu_soc *ipu, struct device *dev, > unsigned long base) > > priv->base = devm_ioremap(dev, base, PAGE_SIZE); > if (!priv->base) { > - kfree(priv); > return -ENOMEM; > } > > -- > 1.7.9.5 > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
