On Tue, Mar 19, 2013 at 02:22:56PM +0100, Michal Nazarewicz wrote: > On Tue, Mar 19 2013, [email protected] wrote: > > The udc_irq service runs the isr_tr_complete_handler which in turn > > "nukes" the endpoints, including a call to rndis_response_complete, > > if appropriate. If the rndis_msg_parser fails here, an error will > > be printed using a dev_err call (through the ERROR() macro). > > > > However, if the usb cable was just disconnected the device (cdev) > > might not be available and will be null. Since the dev_err macro will > > dereference the cdev pointer we get a null pointer exception. > > > > Reviewed-by: Radovan Lekanovic <[email protected]> > > Signed-off-by: Truls Bengtsson <[email protected]> > > Signed-off-by: Oskar Andero <[email protected]> > > Acked-by: Michal Nazarewicz <[email protected]> > > I think this is the best solution. Adding if statements around it would > just add noise.
alright, please re-send without RFC tag and with Michal's acked-by so I can apply. -- balbi
signature.asc
Description: Digital signature
