On 03/27/2013 08:23 PM, Sachin Kamat wrote:
> Return the value obtained from the function instead of hardcoding.
> Silences the following warning:
> drivers/extcon/extcon-max77693.c:297 max77693_muic_set_path()
> info: why not propagate 'ret' from max77693_update_reg() instead of (-11)?
> drivers/extcon/extcon-max77693.c:310 max77693_muic_set_path()
> info: why not propagate 'ret' from max77693_update_reg() instead of (-11)?
>
> Signed-off-by: Sachin Kamat <sachin.ka...@linaro.org>
> ---
> drivers/extcon/extcon-max77693.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max77693.c
> b/drivers/extcon/extcon-max77693.c
> index 8f3c947..894e20e 100644
> --- a/drivers/extcon/extcon-max77693.c
> +++ b/drivers/extcon/extcon-max77693.c
> @@ -294,7 +294,7 @@ static int max77693_muic_set_path(struct
> max77693_muic_info *info,
> MAX77693_MUIC_REG_CTRL1, ctrl1, COMP_SW_MASK);
> if (ret < 0) {
> dev_err(info->dev, "failed to update MUIC register\n");
> - return -EAGAIN;
> + return ret;
> }
>
> if (attached)
> @@ -307,7 +307,7 @@ static int max77693_muic_set_path(struct
> max77693_muic_info *info,
> CONTROL2_LOWPWR_MASK | CONTROL2_CPEN_MASK);
> if (ret < 0) {
> dev_err(info->dev, "failed to update MUIC register\n");
> - return -EAGAIN;
> + return ret;
> }
>
> dev_info(info->dev,
As my comment about "extcon: max8997: Fix return value",
I wish to receive one patch which modify all of return value with 'ret'
in extcon-max77693.c.
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
