On 03/22/2013 03:23 AM, Thomas Gleixner wrote: > cpu_idle() needs to be called with preemption disabled. > > Signed-off-by: Thomas Gleixner <t...@linutronix.de> > Cc: Chris Metcalf <cmetc...@tilera.com> > --- > arch/tile/kernel/smpboot.c | 2 -- > 1 file changed, 2 deletions(-) > > Index: linux-2.6/arch/tile/kernel/smpboot.c > =================================================================== > --- linux-2.6.orig/arch/tile/kernel/smpboot.c > +++ linux-2.6/arch/tile/kernel/smpboot.c > @@ -207,8 +207,6 @@ void __cpuinit online_secondary(void) > /* Set up tile-timer clock-event device on this cpu */ > setup_tile_timer(); > > - preempt_enable(); > -
Hmm, so shouldn't we call preempt_disabled() here? I see that start_secondary() calls preempt_disabled(), but I didn't quite understand as to which of the *_secondary() functions have to call it... especially since its the online_secondary() function which calls cpu_idle(). > cpu_idle(); > } > > > Regards, Srivatsa S. Bhat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
