On 03/29/2013 07:18 PM, Sam Ravnborg wrote: > On Tue, Mar 26, 2013 at 11:54:57PM +0800, Jiang Liu wrote: >> Prepare for removing num_physpages. >> >> Signed-off-by: Jiang Liu <[email protected]> >> Cc: Wen Congyang <[email protected]> >> Cc: Tang Chen <[email protected]> >> Cc: Yasuaki Ishimatsu <[email protected]> >> Cc: [email protected] >> Cc: [email protected] >> --- >> Hi all, >> Sorry for my mistake that my previous patch series has been screwed up. >> So I regenerate a third version and also set up a git tree at: >> git://github.com/jiangliu/linux.git mem_init >> Any help to review and test are welcomed! >> >> Regards! >> Gerry >> --- >> mm/memory_hotplug.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index 97454b3..9b1b494 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/memory_hotplug.c >> @@ -751,10 +751,6 @@ EXPORT_SYMBOL_GPL(restore_online_page_callback); >> >> void __online_page_set_limits(struct page *page) >> { >> - unsigned long pfn = page_to_pfn(page); >> - >> - if (pfn >= num_physpages) >> - num_physpages = pfn + 1; >> } >> EXPORT_SYMBOL_GPL(__online_page_set_limits); > > How can this be correct? > With this change __online_page_set_limits() is now a nop. Hi Sam, We will eventually remove the global variable num_physpages in the last patch. I kept the nop __online_page_set_limits() because I have a plan to use it to fix other bugs in memory hotplug, otherwise it may be killed too. Regards! Gerry
> > Sam > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
